Repository navigation
Prevent overlapping Todo validators and recover their original completion receipt - #8714
Conversation
…20261114 Show human attention inputs and optimization points in Research
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
…history-images-8601 Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com> # Conflicts: # apps/presentation/dashboard/src/data/chat.ts
… failures Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
…lark-triage-8695 Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
…y-images-20261111 Load Steward history images as they come into view
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
…lark-triage-8695 Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
…navigation-20261114 Make saved case studies visible beside research history
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
…lark-triage-8695 Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
…iage-card-20261113 Add read-only Steward shortcut cards to private Lark chat
* fix(todos): preserve arguments in claim recovery commands Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com> * fix(todo): reconcile reviewed updates after claim recovery Use the same targeted readback when execution proof is omitted or the original managed claim has expired. Render the new claim reference and the reconciled provider revision in the retry command. Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com> --------- Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
…8720) Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
Keep the clock-derived first due time out of the create request identity. Derive it at the canonical writer after checking for the original receipt. Preserve the result on retries and continue to reject changes to the authored schedule. Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
…ion (#8731) Canonical Todo timestamps are whole seconds. A review-bound successor created in the admission second was stored earlier than a fractional guard_recorded_at, so lifecycle reconstruction dropped the admitted source and receipt-bound recovery could not settle the original Turn. Compare that successor with the same admission-second bound closeout already uses. Earlier seconds, a different review, and missing or invalid timestamps still keep the inferred edge. Signed-off-by: Duang777 <duangjl007@gmail.com> Co-authored-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
…ssion latest (#8684) * fix(botmux): do not read provider results for unaccepted dispatches On a reused botmux session the status read asked the provider for the session's trigger-result whenever the session held an active dispatch key, even when that dispatch's local receipt was still `attempting` (crash before the provider replied) or `rejected`. The session result then describes the previous, completed turn, so status reported the never-accepted dispatch as `completed` with `readback_verified: true`, and `--execute` crashed with "invalid botmux dispatch transition: rejected->completed" (or attempting->completed), leaving the receipt unresolved forever. Resolve ATTEMPTING and REJECTED receipts from the local receipt alone, the same path used when no session exists: attempting is promoted to unknown and rejected is reported as rejected. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: duang777 <duangjl007@gmail.com> * fix(botmux): keep a never-accepted unknown dispatch local on repeated status The first status turned an interrupted attempt into an unknown receipt, but the next status took the provider path again and, on a reused session, adopted the previous accepted turn's trigger-result for the new dispatch key: completed and readback_verified, persisted. Treat an UNKNOWN receipt that was never QUEUED (an interrupted attempt, a transport failure or an unverifiable receipt) like ATTEMPTING and REJECTED and resolve it from the local receipt alone. An UNKNOWN that was QUEUED and only lost its status read still recovers through the provider. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: duang777 <duangjl007@gmail.com> * fix(botmux): read the turn a receipt was queued under, not the session's latest An accepted dispatch was read back with the session's trigger-result, which is the latest turn of the session. When another client started and finished a newer turn after this one failed, status reported that turn's completion for this dispatch: the preview said completed and --execute persisted it. Ask for the trigger id stored on the receipt and promote a provider state only when the response names that same id. A response for another turn, one that names no turn, or a receipt with no stored trigger id is reported as unknown with unknown_reason trigger_identity_unverified, never as a completion; a terminal local state is still not overwritten by it. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: duang777 <duangjl007@gmail.com> * fix(botmux): check the turn named by a not_found response too The identity check skipped not_found, on the reasoning that a missing result echoes the id it was asked for. A response that names another turn as not_found was therefore accepted: status reported not_found with that turn's output attached and --execute persisted a terminal not_found that no later state may replace, so this request's real completion could never be recorded. Verify the triggerId of every response for a pinned turn, not_found included. The bare session-level missing branch (404 unknown_session naming no turn) is kept as it was; a 404 that does name a turn is checked like any other. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: duang777 <duangjl007@gmail.com> * fix(botmux): keep only an explicit unknown_session as session-level missing The exception for a not_found that names no turn accepted any 404 with state not_found, so a generic 404 with no triggerId could still seal an accepted receipt as a terminal not_found that no later state may replace. Treat a response as session-level missing only when it is an explicit unknown_session naming no turn. A generic 404 not_found, or one naming a turn, is verified against the request's trigger id like every other response. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: duang777 <duangjl007@gmail.com> --------- Signed-off-by: duang777 <duangjl007@gmail.com> Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com> Co-authored-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
…8735) #8431 retired the stored activation_state alias and status=stopped as registry protocol errors. Two Steward tests still wrote those fields and failed with ProjectRegistryProtocolError; three more passed only because the protocol error happened to look like a rejection. Write the canonical activation object so each case exercises the real stopped-Goal path. Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
… canonical content_digest consumers (#8910) Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
…chet module budget (#8884)
…covery-fairness-20261117 Keep original Lark replies and App discovery moving under backlog
…age-collection-20261117 Avoid rereading portfolio rows discarded by pagination
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
…larize-20261117 fix(cli): accept inline JSON in refresh-state, add spend-slot --delivery-workspace-path, and modularize CLI command modules
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
…-regression-20261117 Retain the supported-CLI cleanup refusal regression. Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
…ecovery-20261118 fix(manager): recover decisions from oversized portfolio rows
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
…teness-20261118 fix(manager): disclose omitted records in every read view
…ock-20261117 fix(benchmark): share native task clocks across Frontier trials
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
…s-20261118 fix(manager): recover oversized Todo details through bounded pages
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
…duplicate-20261111 feat(reward-memory): skip duplicate turn reflections
…ke-request-attribution Count benchmark worker quota guards in trajectory usage
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
loopx-agent
left a comment
There was a problem hiding this comment.
Reviewer: model_agent | model=gpt-6.2-sol | provider=OpenAI | reasoning_effort=max | source=runtime_reported
Request changes conclusion (author-owned PR; GitHub blocks formal self-review)
原评审的 P2 已在 File 和 SQLite 上复验修复。当前合并资格仍缺 PostgreSQL 真实后端证据,复核中没有发现新的源码阻塞项。
动机 / Motivation
从 CLI 或 Chat 重试 Todo 完成的操作者,需要知道原校验是否还在运行,以及原完成结果能否恢复。 原先,一个校验主进程退出后,同组子进程可能继续处理产物,而第二次完成已开始。当前头把进程组收尾放在同一执行锁内,并能在完成响应丢失后读回原收据。 本机验证已确认同一个 Todo 的校验完成后才接受另一尝试,已提交的同一请求只读回原收据。 受影响的 PostgreSQL 后端仍缺少绑定本提交的实际验证。 本提案覆盖同一运行时目录的 Todo 完成和收据恢复。跨机执行与 Windows 调用者退出后的清理各有独立资格。
改动思路 / Approach
保留已有 TypeScript 事务作为准入与终态 owner,由本机 supervisor 持有原执行锁直至同组进程停止。原收据依然来自事务。 当前边界是 Todo 完成调用的本机串行执行、明确失败和原操作读回。 仅等待主进程退出无法证明其同组子进程已停止。监督进程继承当前 Todo 的文件锁,直到收尾结束。校验前复检同一个准入和收据,提交仍通过原有事务。响应不明确时先查原操作,查不到收据也不能据此认定先前写入已停止。
具体改动 / Changes
受审提交 fcdc512e264e61b0abaca14a3426c4341104986d。GitHub 展示的旧基线包含主干继承差异。以实际共同祖先 513b6f168a405d5c071c79ae23fb18d2b4f5ae5d 重算是 15 文件,+911/-93。上一评审绑定 5006f8b0a6991e44cfcae7a5d89de4688be00991,本轮用同一套输入重验其 P2,并覆盖整个现行提案的本机锁、用户完成入口、原收据和 Chat 错误。参照 Todo 完成契约,spec_ref docs/project-agent-todo-contract.md,spec_revision 513b6f168a405d5c071c79ae23fb18d2b4f5ae5d。
- Declared validation 已通过本机 File/SQLite 实验。两类完成入口都在持锁后复检,失败不提交完成。
- No-validator fast path 普通无校验器的 File/SQLite 更新在两个版本均通过。
关键代码讲解
- _run_validator 在校验返回前清理并确认自有进程组。成功、失败和调用方中断沿用这一收尾路径。
- try_posix_child_retained_file_lock 让调用方退出后监督进程仍可持有同一把锁,锁的作用域保持在当前运行时的 Todo。
- _dispatch_terminal_with_validation 在执行前复检原操作。已提交的完成直接重放,避免再次执行校验。
- ambiguous_todo_write 为不确定的终态响应生成原操作的只读查收命令。Chat 重试同一已审核提案取得原结果。
对主干的风险 / Risks
相同 File/SQLite 与 complete/update 输入下,主干 8 组仍有同组子进程运行,候选 8 组都在返回前确认其停止并保留回执重放。另 4 组无法启动校验器的输入在候选有结构化拒绝且状态不变。两种后端另测同一个 Goal 的独立 Todo,校验期间仍可完成该 Todo;主干和候选都要求原操作在来源版本变更后重新校验,确认为现有版本围栏。打包 Chat 25 项通过,覆盖忙时保留原申请和最终读回。原 96 项组合首次 94 过、2 败,其中一项是尚未构建资源的 404,一项是校验启动超出测试等待。两项后来分别重跑通过,启动超时的具体原因仍未证实。在更新后的主干 3c03e91e6736f129d78e7c895b9d4a871f132a7f 与候选组合上,17 项真实 CLI 检查通过,包括停止同组子进程、原收据恢复及 Markdown 恢复命令。
语义与 CI 对齐
保持现有 Todo 校验、操作身份和回执词汇,运行中的拒绝有受控范围,收据查询本身只读。35 项 TS 测试、类型检查和精确 15 文件的预合并 6 项直接与 17 项选中检查通过。本机 PostgreSQL 镜像存储 I/O 错误阻止真实服务启动,故受影响后端资格仍未证实。请在隔离真实 PostgreSQL 实例补齐同一提交的校验并发、终态提交响应丢失、原收据读回和重放,并重新核验精确范围发出的质量回执。实际工作只使用本地验证,托管 CI 单列。
我的整体评价 / Verdict
本机长期接续和操作者的重试路径已有实际改善,完整后端资格仍待验证。保留已有 TypeScript 事务作为准入与终态 owner,由本机 supervisor 持有原执行锁直至同组进程停止。原收据依然来自事务。 当前边界是 Todo 完成调用的本机串行执行、明确失败和原操作读回。 采用现有操作身份便可收尾,无须新增一次人工确认。已核对编译后的 Chat HTTP 正常、冲突和恢复路径。页面组件与首屏布局没有改动,视觉评审不适用。 Windows 调用方退出后的行为和正式安装运行未验证。当前保留所需 PostgreSQL 证据缺口及同一提交的合并门。
English verdict: REQUEST_CHANGES at fcdc512e264e61b0abaca14a3426c4341104986d for missing required real PostgreSQL validation. The previous overlapping POSIX validator finding is resolved on File and SQLite, and exact receipt recovery and packaged Chat retry were verified. No new source defect was established.
loopx-agent
left a comment
There was a problem hiding this comment.
Reviewer: model_agent · gpt-6.2-sol · OpenAI (runtime_reported, max)
Approval conclusion (author-owned PR; GitHub blocks formal self-approval)
动机 / Motivation
通过 CLI 或 Chat 完成 Todo 的操作者需要知道第一次校验是否还在运行,以及怎样恢复已经提交的原结果。上一份同头评审确认 File/SQLite 原问题已修,并因独立真实 PostgreSQL 证据不足保留请求修改。本轮对同一提交补做真实 PostgreSQL、TLS CLI 和当前主干组合。已确认同版本对手仅提交一次,丢失终态响应后可按原请求恢复。本次复审聚焦落盘、收据复用和能够证明的 POSIX 主机作用域。
改动思路 / Approach
TypeScript 事务保有准入、终态和收据 owner。Python 仅处理本机单 Todo 校验锁及 POSIX 进程组。CLI、Chat 和远程终态沿原 operation id 读回。当前精确头覆盖两类本地完成入口、校验监督、原收据恢复和文档。PostgreSQL 复测另核事务 CAS 与真实 TLS 命令。隔离运行已解包 PostgreSQL 16.15。配对比较同 revision 的两条事务与实际丢失响应的 TLS 命令,并复核 File/SQLite 两类入口的并发、同组清理及原回执。以当前测试在真实共同祖先复现八组,重定向子进程仍在运行;现提交的同组测试已通过。
具体改动 / Changes
精确 head fcdc512e264e61b0abaca14a3426c4341104986d,diff base 513b6f168a405d5c071c79ae23fb18d2b4f5ae5d,15 个文件 +911/-93。逐项复核 single-local-validator、original-terminal-recovery、live-db-provider、normal-callers-and-failure。验收约定
关键代码讲解
- 本机 supervisor 在原校验进程退出后仍清理同组子进程。同一运行时、同一 Todo 的锁覆盖完成前读取到终态写入。源码
- 两种完成入口在持锁后复检操作与版本。33 项真实 File/SQLite CLI 检查验证进程清理、不可执行校验、重试和原收据读回。源码
- 隔离 PostgreSQL 16.15 的两个同版本请求只提交一次。重启真实 TLS 服务后,按原请求找回相同收据,Todo、释放的租约和版本读回一致。源码
- 实际主干取共同祖先比较只涉及 15 路径。叠加 #9046 的组合在最新主干通过两项关键 PostgreSQL 复测。源码
- Chat 遇到同一个校验仍执行时返回 409,保留首个提案的状态供原请求读回。源码
对主干的风险 / Risks
独立复测的 PostgreSQL 存储 398、远程 TLS 53、服务 11、定向 2,均零失败和跳过。实际主干组合也通过两项定向用例。POSIX 测试观察本机同组子进程。远程 TLS 用例验证原事务恢复,声明校验器并未在 TLS 用例运行。Windows 调用方异常退出、跨主机互斥以及正式安装采用仍无本轮证据。
语义与 CI 对齐
现有 Goal、版本、租约和校验约定有效,查收原操作只读。未找到收据时仍须保留原写入可能执行的状态。历史同头独评提出的 PostgreSQL 验证缺口已补齐,现有合并资格继续按独立流程核验。
我的整体评价 / Verdict
批准当前精确提交。原本机进程组问题的修复保持有效。真实 PostgreSQL 的并发及 TLS 重启恢复补齐了上一份评审的阻塞证据,#9046 与实际主干组合的复测也通过。
English verdict: APPROVE. Real PostgreSQL 16.15 validates exactly one terminal commit and original-receipt recovery after TLS service restart on this unchanged head. The prior PostgreSQL evidence gap is closed.
Result
Todo 完成请求现在会在同一执行锁内复检准入、运行声明的校验器并恢复原完成回执。POSIX supervisor 在返回前清理整个自有进程组:校验主进程退出且输出流关闭,不能再使仍运行、已重定向输出的子进程越过锁边界。成功与失败退出、超时、取消和观察异常共用一个
finally清理出口,复用现有进程终止与停止确认逻辑。这修复了原精确头评审中的 P2:第一次校验的子进程仍可写入时,重试已经再次运行校验并提交 Todo。TypeScript 事务继续拥有准入、操作身份、终态提交和回执重放;Python 负责现有的主机进程监督。已提交操作的重放保持不再执行校验器。
提交:
fcdc512e264e61b0abaca14a3426c4341104986d;验证目标:513b6f168a405d5c071c79ae23fb18d2b4f5ae5d。保留原作者提交和 DCO,以正常快进更新原分支。Validation
todo complete/todo update --status done× 成功/失败主进程,8 组在整合主干后的未修复实现上全部失败;同一测试在修复后全部通过。直接观察子进程已停止,并检查无迟到写入、失败不改 Todo、原请求重试和完成回执重放。typecheck:control-plane通过。complete响应后,重启服务可读回原回执并重放,Todo 终态、已释放租约、回执和来源版本均保持一致。首次完整测试为 109 passed/10 failed:干净 editable 源码尚无生成的 Chat 入口资源,10 项 HTTP 检查返回 404。随后使用本提交的
scripts/chat_bundle.py build --install与verify --source,构建并核验 36 个交付文件,再完整运行上述 7 模块取得 211/3 的结果。保留首次失败,未删除或跳过相关断言。Remaining qualification
托管验证从记录中的合成合并提交运行。它的 Git 树与作者提交完全一致,报告中的 10 个探针文件哈希也已逐项核对。当前质量记录已接入真实后端证据。原本机 Docker 镜像读取失败、首次范围资格不通过和首次复跑超时的记录均保留。本提交仍待独立复审和最终合并检查。 本机复现沿用 PostgreSQL 终态验证契约 与 真实 TLS 测试夹具。前一条定向复现在 PostgreSQL 事务 owner 同时提交已执行校验的回执,后一条通过实际远程命令;本机 POSIX 进程组串行与强制清理来自上表 File/SQLite 测试。 待复核的精确头评审。
当前证据覆盖 macOS 上的 POSIX 同进程组边界。Windows 保留调用者存活期间的串行校验能力;本地未资格化 Windows 调用者退出后的清理、真实跨主机中断、Lark 或已安装用户升级。已有依赖审计告警仍在:root 安装报告 4 moderate,dashboard 安装报告 5 high;未更改依赖或 lockfile。
Published comparison
GitHub PR 固定目标快照为
78e936f9d1f1a00505c4026ee0a5857de95cee27,当前页面展示 932 文件、+70097/-40442。已完整读取 10 页文件清单并逐项比较不可变 Git 对象:917 项与本次正式验证目标相同(含两边均不存在的历史项),实际变化只有 15 文件、+911/-93;现存头文件的 API blob SHA 全部匹配。请使用精确目标与本头的比较及原评审框架检查本次提案。目标分支仍为main,没有刷新目标元数据。验证后主干合入了 C1 默认工作契约。在主干 3c03e91 与原提交的隔离合并树中补测 Todo Markdown、原生完成、操作回执与 Turn 结算,首轮 131 项通过、10 项 Windows 专用跳过,另 6 项 HTTP 用例因缺少 Chat 打包资源而返回 404。从同一源码树重建并验证 Chat bundle 后,6 项 HTTP 用例全部通过。 GitHub PR 仍使用上述原提交,合并资格继续按实际目标核对。
本提案已交付源码修复和同树 PostgreSQL 验证。独立结论、实际合并及正式发行仍按各自条件验收。